Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade guardian controller to 1.7 #195

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

danielsp45
Copy link
Member

No description provided.

@reviewpad
Copy link

reviewpad bot commented Sep 23, 2023

AI-Generated Summary: This pull request contains a number of changes primarily aimed at refactoring and upgrading the guardian controller from 1.6 to 1.7. It involves modifications in four files with 17 insertions and 18 deletions.

The notable changes are following:

  • In the UserController and GuardianController, BokkenWeb has been used with :controller instead of "1.6". This indicates an upgrade from version 1.6 to 1.7.
  • The render function calls in UserController and GuardianController have been updated to use atom keys rather than string keys.
  • The response header in GuardianController's create function is updated to use string interpolation instead of using Routes.guardian_path for location.
  • The guardian_view.ex file has been renamed to guardian_json.ex and transformed into a controller file. In addition, It changed all the render functions to individual functions named after what they render such as index, show and guardian.
  • Similar changes have been made for the Admin.GuardianView file, replacing render function calls with index and guardian functions.

@danielsp45 danielsp45 force-pushed the dp/upgrade-guardian-controller branch 6 times, most recently from 1c83a4b to b31e714 Compare September 25, 2023 16:56
Copy link
Member

@ruilopesm ruilopesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to replace this.

image

@danielsp45 danielsp45 force-pushed the dp/upgrade-guardian-controller branch from b80df97 to b1e5b3f Compare November 6, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants